> On 2011-08-17 21:26:38, Henry Saputra wrote: > > Ugh, this is why we need review and JIRA case =( > > > > WIll patch this one. Thanks Dan. > > Dan Dumont wrote: > No problem. I've been adding jira's to my reviews (maybe not right > away, but eventually). > > This original submission also should have had both. I'm not sure > exactly how the dupe code got in there, we had a really hard time internally > applying this patch because of many nested move/rename operations for files > renamed to -size from -height. > > Can we just use the original jira for this patch?
Dan I don't think this was our fault. I went back and looked at the review from the dynamic-width patch and we did not touch this file in that patch. I went back and took a look at the history of the file and that code has been there for a while. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1577/#review1513 ----------------------------------------------------------- On 2011-08-17 21:11:43, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1577/ > ----------------------------------------------------------- > > (Updated 2011-08-17 21:11:43) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Remove duplicate code accidentally included > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js > 1158915 > > Diff: https://reviews.apache.org/r/1577/diff > > > Testing > ------- > > > Thanks, > > Dan > >
