----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1527 -----------------------------------------------------------
Ship it! Thanks for the explanation Dan. LGTM. +1 - Henry On 2011-08-17 15:18:59, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1525/ > ----------------------------------------------------------- > > (Updated 2011-08-17 15:18:59) > > > Review request for shindig. > > > Summary > ------- > > If gadgets.util.registerOnLoadHandler was called after the runOnLoad > counterpart was called, the callback would sit in the array... forever alone. > > > This addresses bug SHINDIG-1578. > https://issues.apache.org/jira/browse/SHINDIG-1578 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js > 1157211 > > Diff: https://reviews.apache.org/r/1525/diff > > > Testing > ------- > > > Thanks, > > Dan > >
