-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1563/
-----------------------------------------------------------
(Updated 2011-08-25 15:32:43.908637)
Review request for shindig.
Changes
-------
Updates per Ryan's review.
Summary
-------
Common container currently supports a one-time bulk preload of gadget metadata
and security tokens via the opt_config parameter passed to the Container
constructor, however it would also be useful to have a way to incrementally
preload this data as well.
We're currently doing this in Apache Rave by calling the private
container.preloadFromConfig_ function for each of our gadgets before calling
container.navigateGadget which seems to work just fine, but we obviously don't
want to continue to rely on a private function.
I'm attaching a patch to make the preloadFromConfig_ function public -- if this
looks good to everyone I would be happy to go ahead and submit a patch against
the container specification for this change as well.
This addresses bugs RAVE-172 and SHINDIG-1579.
https://issues.apache.org/jira/browse/RAVE-172
https://issues.apache.org/jira/browse/SHINDIG-1579
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1157893
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml
1137021
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js
1086837
Diff: https://reviews.apache.org/r/1563/diff
Testing
-------
Additional unit tests added as well as testing in the browser using sample
common container.
Thanks,
Jesse
