----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1657/#review1657 -----------------------------------------------------------
Ship it! +1 - Henry On 2011-08-26 11:22:35, Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1657/ > ----------------------------------------------------------- > > (Updated 2011-08-26 11:22:35) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > osapi.container.GadgetSite.prototype.render fails to render a gadget using a > given view when that gadget does not explicitly define that view, even in the > case where the container configuration has aliases for that view. > > For instance, Gadget A supports the "profile" and "canvas" views only. The > container configuration defines the "home" view and provides "profile" as an > alias for "home". In the use case where the container tries to render Gadget > A using the "home" view, gadget render will fail, even though the gadget > supports "profile" and it has been specified as an alias for "home" in the > container configuration. > > This problem commonly manifests itself in Shindig because of the way > "default" views are handled. By default, Shindig will attempt to render the > gadget using the "default" view. If the gadget does not support that view, > rendering will fail. > > > This addresses bug SHINDIG-1596. > https://issues.apache.org/jira/browse/SHINDIG-1596 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1160327 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js > 1160327 > > Diff: https://reviews.apache.org/r/1657/diff > > > Testing > ------- > > Tested rendering a gadget in the "default" view case where the gadget doesn't > support default. > > > Thanks, > > Stanton > >
