----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1663/#review1679 -----------------------------------------------------------
Ship it! LGTM looks like Henry committed this already. Please close the review and the JIRA. - Ryan On 2011-08-25 22:20:42, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1663/ > ----------------------------------------------------------- > > (Updated 2011-08-25 22:20:42) > > > Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. > > > Summary > ------- > > minor bug fix to inject hostProvider to JsonDbOpensocialSerivce > Need to inject hostProvider to JsonDbOpensocialService > @Inject(optional = true) > public void setHostProvider( Provider<Authority> hostProvider) { > this.hostProvider = hostProvider; > } > > > This addresses bug SHINDIG-1597. > https://issues.apache.org/jira/browse/SHINDIG-1597 > > > Diffs > ----- > > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1161655 > > Diff: https://reviews.apache.org/r/1663/diff > > > Testing > ------- > > passed junit tests > > > Thanks, > > li > >
