----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1635/#review1698 -----------------------------------------------------------
Ship it! Committed revision 1163432. Please close review and JIRA. - Ryan On 2011-08-25 21:16:54, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1635/ > ----------------------------------------------------------- > > (Updated 2011-08-25 21:16:54) > > > Review request for shindig, johnfargo and Ryan Baxter. > > > Summary > ------- > > I ran into an issue loading the container across domains with the recent > change. This should fix it. > > I'd like to add that this code could be drastically simplified if this were > fixed: > https://bugs.webkit.org/show_bug.cgi?id=43504 ( has 2 bugs linked in the > description for the areas that need fixing ). > > Currently in webkit, cross-origin errors are not throwing catch-able errors > and pollute the console quite considerably in chrome and safari. > I don't suppose anyone knows any webkit committers who could update and push > this patch? From the comments it looks like the community has come around in > support of the change, but the original author of the patch doesn't have the > time anymore to pursue it. > > > This addresses bug SHINDIG-1594. > https://issues.apache.org/jira/browse/SHINDIG-1594 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js > 1160787 > > Diff: https://reviews.apache.org/r/1635/diff > > > Testing > ------- > > > Thanks, > > Dan > >
