----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1729/#review1771 -----------------------------------------------------------
Ship it! LGTM http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js <https://reviews.apache.org/r/1729/#comment4050> Optional: remove trailing space. - Paul On 2011-09-06 17:33:32, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1729/ > ----------------------------------------------------------- > > (Updated 2011-09-06 17:33:32) > > > Review request for shindig. > > > Summary > ------- > > Fixes use of undefined variable in dynamic width feature. > > This error starts showing up when you use the feature and your gadget > declares version 2.0 of the spec, which by default causes the doctype to be > html5. > Without the declaration, documents would render in quirks mode, which would > cause the width calculations to take a different code path. > > > This addresses bug SHINDIG-1614. > https://issues.apache.org/jira/browse/SHINDIG-1614 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js > 1165734 > > Diff: https://reviews.apache.org/r/1729/diff > > > Testing > ------- > > > Thanks, > > Dan > >
