> On 2011-09-20 08:41:49, Paul Lindner wrote:
> > thanks!
> >

Addressed in the second patch for
https://reviews.apache.org/r/1947/


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1960/#review1969
-----------------------------------------------------------


On 2011-09-19 20:32:06, Brian Lillie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1960/
> -----------------------------------------------------------
> 
> (Updated 2011-09-19 20:32:06)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, 
> it passes a message key expecting the Logging call to translate the msgKey 
> into a message. However, no resource bundle was associated with the logger so 
> the translation does not occur. 
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1625.
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1625
> 
> 
> Diffs
> -----
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java
>  1164090 
> 
> Diff: https://reviews.apache.org/r/1960/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brian
> 
>

Reply via email to