----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2028 -----------------------------------------------------------
The first pass of this looks ok. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java <https://reviews.apache.org/r/2025/#comment4576> What are these comments commenting? The "isHostUsingLockedDomain" call? Doesn't seem likely... http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java <https://reviews.apache.org/r/2025/#comment4577> DefaultIFrameUriManager had some comments about overriding to implement custom behavior. Let's add that back in. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java <https://reviews.apache.org/r/2025/#comment4578> This was because %authority% was being replaced with the locked-domain, right? That is, the authority value had the hash prefix in it? - Stanton On 2011-09-22 20:55:37, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2025/ > ----------------------------------------------------------- > > (Updated 2011-09-22 20:55:37) > > > Review request for shindig, johnfargo, Ryan Baxter, and Stanton Sievers. > > > Summary > ------- > > Sorry for the crazy diffs here. Much stuff has moved around. > This is the cleanup part of the patch, I want a few good eyes first before I > move on to the feature work. > > Some highlights: > > * org.apache.shindig.gadgets.uri.DefaultIframeUriManager > Nearly everything relating to locked domains has been moved to > org.apache.shindig.gadgets.LockedDomainService > Removed validation on uri for locked domains from this class. It was never > actually used. > > * org.apache.shindig.gadgets.uri.ProxyUriBase > Removed check for INVALID_DOMAIN, nothing in the code paths leading there > ever set that status. > > * org.apache.shindig.gadgets.uri.UriStatus > Removed INVALID_DOMAIN, it was not used anymore. This class seems more > focused on caching anyway. > > * org.apache.shindig.gadgets.HashLockedDomainService > Implemented new methods added to interface. Renamed some methods for clarity > and java convention. > Augmented some existing implementation from code that used to be in > org.apache.shindig.gadgets.uri.DefaultIframeUriManager > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java > 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java > 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java > 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java > 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriStatus.java > 1174376 > > http://svn.apache.org/repos/asf/shindig/trunk/php/test/gadgets/ContainerConfigTest.php > 1174376 > > Diff: https://reviews.apache.org/r/2025/diff > > > Testing > ------- > > > Thanks, > > Dan > >
