----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2035/#review2039 -----------------------------------------------------------
LGTM, though I'm not familiar yet with those deps. Did you ever get to update the closure compiler dep, or did you leave as-is because of the error we had consuming it the last time? - Dan On 2011-09-23 09:06:17, Paul Lindner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2035/ > ----------------------------------------------------------- > > (Updated 2011-09-23 09:06:17) > > > Review request for shindig. > > > Summary > ------- > > Deps upgrade. > > > Diffs > ----- > > /trunk/pom.xml 1174464 > > Diff: https://reviews.apache.org/r/2035/diff > > > Testing > ------- > > EndToEnd tests (which use htmlunit) working correctly. > Existing parser tests pass. > Smoke test of gadgets working. > > > Thanks, > > Paul > >
