----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2038/#review2057 -----------------------------------------------------------
Ship it! LGTM Out of curiosity, how did you determine all of the uses? - Stanton On 2011-09-23 17:03:55, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2038/ > ----------------------------------------------------------- > > (Updated 2011-09-23 17:03:55) > > > Review request for shindig and johnfargo. > > > Summary > ------- > > The uses elements can be used to secure which RPC endpoints gadgets will be > allowed to call. The export elements are not used currently but we should add > them for completeness. > > > This addresses bug SHINDIG-1629. > https://issues.apache.org/jira/browse/SHINDIG-1629 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/opensocial-payment/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/wave/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/auth-refresh/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-jsonrpc/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-reference/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/osapi/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/pubsub/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/setprefs/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/settitle/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/feature.xml > 1174813 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/views/feature.xml > 1174813 > > Diff: https://reviews.apache.org/r/2038/diff > > > Testing > ------- > > Ran unit tests > > > Thanks, > > Ryan > >
