----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2179/#review2338 -----------------------------------------------------------
Ship it! Sorry for being late here and I realize this has already been submitted but this all looks good to me. Thanks Henry! - Ryan On 2011-10-04 22:01:27, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2179/ > ----------------------------------------------------------- > > (Updated 2011-10-04 22:01:27) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Inject ServerAdminData in the BasicGadgetAdminStore to allow extension of the > class. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStore.java > 1178920 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ServerAdminData.java > 1178920 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java > 1178920 > > Diff: https://reviews.apache.org/r/2179/diff > > > Testing > ------- > > Pass unit test and run the embed Jetty > > > Thanks, > > Henry > >
