I'd be fine with committing sooner. Code reviews are great and all, but if the code is in trunk then I can propose patches on top.
On Wed, Oct 12, 2011 at 8:07 AM, Eric Woods <[email protected]> wrote: > Updated patches have been posted for the OAuth 2.0 implementations, both > client and service provider. > > Client: https://reviews.apache.org/r/1947/ > Documentation: > http://docs.opensocial.org/display/OSD/OAuth+2.0+Consumer+Implementation+in+Apache+Shindig > > Service provider: https://reviews.apache.org/r/1940/ > Documentation: > https://cwiki.apache.org/confluence/display/SHINDIG/OAuth+2.0+Service+Provider+Implementation+in+Apache+Shindig > > This code has seasoned pretty well and addresses all community feedback to > date. Pending additional feedback, I'll commit these two patches Friday > evening. > > Thanks everyone! > - Eric W. -- Paul Lindner -- [email protected] -- linkedin.com/in/plindner
