----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2052/#review2587 -----------------------------------------------------------
/trunk/content/samplecontainer/examples/conservcontainer/index.html <https://reviews.apache.org/r/2052/#comment5817> remove whitespace /trunk/content/samplecontainer/examples/conservcontainer/index.html <https://reviews.apache.org/r/2052/#comment5818> +18 seems a little fragile. Why not define /conservcontainer/ as a var and then get the length of the string /trunk/content/samplecontainer/examples/conservcontainer/index.html <https://reviews.apache.org/r/2052/#comment5819> remove the white space /trunk/content/samplecontainer/examples/conservcontainer/index.html <https://reviews.apache.org/r/2052/#comment5820> remove the white space and make sure it lines up - Ryan On 2011-10-12 20:54:19, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2052/ > ----------------------------------------------------------- > > (Updated 2011-10-12 20:54:19) > > > Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. > > > Summary > ------- > > The fix will set up API patch when common container is created in these > sample pages. > > var testConfig = testConfig || {}; > testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc'; > var CommonContainer = new osapi.container.Container(testConfig); > > also includes other minor cleanup. > > > This addresses bug SHINDIG-1632. > https://issues.apache.org/jira/browse/SHINDIG-1632 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/conservcontainer/index.html 1182418 > > Diff: https://reviews.apache.org/r/2052/diff > > > Testing > ------- > > passed maven build. > > > Thanks, > > li > >
