----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/#review2653 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java <https://reviews.apache.org/r/2425/#comment5971> else if, to avoid checks if the 1st one matched. - Dan On 2011-10-18 18:13:24, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2425/ > ----------------------------------------------------------- > > (Updated 2011-10-18 18:13:24) > > > Review request for shindig and Dan Dumont. > > > Summary > ------- > > If there is a gadget in the admin store, for example > http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml > shindig does not think http://foo.com:80/gadget.xml is the same as > http://foo.com/gadget.xml are the same gadget so it does not think the gadget > should be allowed to render. > > > This addresses bug SHINDIG-1643. > https://issues.apache.org/jira/browse/SHINDIG-1643 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java > 1185758 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java > 1185758 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java > 1185758 > > Diff: https://reviews.apache.org/r/2425/diff > > > Testing > ------- > > Updated unit tests to test new functionality > > > Thanks, > > Ryan > >
