----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2572/ -----------------------------------------------------------
Review request for shindig and Brian Lillie. Summary ------- If a gadget uses OAuth but requires no other features that depend on the "security-token" feature, a security token is not returned on the iframeurl when it should be. This stems from the fact that ModulePrefs.getViewFeatures() doesn't pick up the artificially added "security-token" feature that gets added by the FeatureVisitor if the OAuthVisitors found oauth tags. Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java 1189151 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java 1189151 Diff: https://reviews.apache.org/r/2572/diff Testing ------- Updated existing JUnits and added new JUnits. Thanks, Stanton
