----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2640/#review2947 -----------------------------------------------------------
Ship it! LGTM - Jesse On 2011-10-31 12:28:02, Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2640/ > ----------------------------------------------------------- > > (Updated 2011-10-31 12:28:02) > > > Review request for shindig. > > > Summary > ------- > > The following lines in shindig.properties have been deprecated in favor of > defining them in container.js. It seems they were implemented in container.js > but the old configuration was never removed. > > shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url= > shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default& > > > > This addresses bug SHINDIG-1654. > https://issues.apache.org/jira/browse/SHINDIG-1654 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties > 1190346 > > Diff: https://reviews.apache.org/r/2640/diff > > > Testing > ------- > > Build/Junit passed > > > Thanks, > > Stanton > >
