> On 2011-11-02 00:28:45, Ryan Baxter wrote: > > One small nit, otherwise LGTM
Committed revision 1196683. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/#review3003 ----------------------------------------------------------- On 2011-11-01 18:12:28, Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2648/ > ----------------------------------------------------------- > > (Updated 2011-11-01 18:12:28) > > > Review request for shindig, Ryan Baxter and Dan Dumont. > > > Summary > ------- > > This patch is to illustrate the minimal set of changes needed to allow the > BlobCrypterSecurityTokenCodec to have a key provided by the config instead of > needing a key file to be provided. > > > This addresses bug SHINDIG-1636. > https://issues.apache.org/jira/browse/SHINDIG-1636 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java > 1195457 > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1195457 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java > 1195457 > > Diff: https://reviews.apache.org/r/2648/diff > > > Testing > ------- > > Updated existing JUnits and added one more. > > > Thanks, > > Stanton > >
