----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2798/ -----------------------------------------------------------
Review request for shindig. Summary ------- HI All, Currently ContentRewriterFeature.Factory exposes 3 methods to get Config via HttpRequest, Uri, and GadgetSpec. This patch is the first step trying to reduce ways to create Config. We dont need gadget Uri method bc most of the times you get gadget URI when you have GadgetSpec so might as well use the ContentRewriterFeature.Factory .get() method with GadgetSpec. I'd love to remove the ContentRewriterFeature.Factory.get with HttpRequest input param but currently its used by the CssResponseRewriter and SanitizingResponseRewriter classes. Diffs ----- trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ContentRewriterFeature.java 1200477 trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ImageResizeRewriter.java 1200477 trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ProxyingContentRewriter.java 1200477 trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ScriptConcatContentRewriter.java 1200477 trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleConcatContentRewriter.java 1200477 trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/StyleTagExtractorContentRewriter.java 1200477 trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ImageResizeRewriterTest.java 1200477 Diff: https://reviews.apache.org/r/2798/diff Testing ------- Compiled and passes unit tests. Thanks, Henry
