> On 2011-11-29 13:09:24, Jesse Ciancetta wrote: > > Nevermind my comment about the new "default.domain.*" properties -- after > > another look this morning with fresh eyes I see that they are used within > > container.js itself... > > > > I did a quick search through the codebase for "jsUriTemplate" and I found a > > reference in a test PHP file -- if you remove it from container.js it might > > make sense to remove it from the PHP file too. > > > > Assuming you've tested the changes in an actual locked domain environment > > to be sure everything is still working properly then I say LGTM.
Ok. I'll update the test and then commit. TY for the reviews, everyone. :) - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2950/#review3554 ----------------------------------------------------------- On 2011-11-28 20:27:24, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2950/ > ----------------------------------------------------------- > > (Updated 2011-11-28 20:27:24) > > > Review request for shindig, Ryan Baxter and Stanton Sievers. > > > Summary > ------- > > I've attempted to make it a little easier for people to enable locked domains > by clarifying some comments and marking critical configuration sections. > > Please, if I've misinterpreted or misrepresented a config setting, let me > know. > > Will attach a JIRA if necessary. I did want some comments before submitting > something like this though. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1207269 > > Diff: https://reviews.apache.org/r/2950/diff > > > Testing > ------- > > All tests pass. > > > Thanks, > > Dan > >
