----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3005/#review3616 -----------------------------------------------------------
Ship it! LGTM - Stanton On 2011-12-04 19:53:37, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3005/ > ----------------------------------------------------------- > > (Updated 2011-12-04 19:53:37) > > > Review request for shindig and Stanton Sievers. > > > Summary > ------- > > When preloading a gadget the response usually is an array of gadget URLs with > data about the gadget. However sometimes the response may actually just be an > error code and message. We need to account for that case in the handler in > the EE code. > > > This addresses bug SHINDIG-1666. > https://issues.apache.org/jira/browse/SHINDIG-1666 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1210178 > > Diff: https://reviews.apache.org/r/3005/diff > > > Testing > ------- > > Ran unit tests and common container > > > Thanks, > > Ryan > >
