> On 2012-01-06 13:04:27, Stanton Sievers wrote: > > LGTM
Committed revision 1228695. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3402/#review4222 ----------------------------------------------------------- On 2012-01-06 02:10:55, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3402/ > ----------------------------------------------------------- > > (Updated 2012-01-06 02:10:55) > > > Review request for shindig. > > > Summary > ------- > > SHINDIG-1669 is not working as expected in all situations and is causing to > many failures, best to revert it for now until we come up with a better > solution. The only file I did not revert is viewenhancements-container.js > because those changes were for other bugs. > > > This addresses bug SHINDIG-1679. > https://issues.apache.org/jira/browse/SHINDIG-1679 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml > 1227888 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js > 1227888 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1227888 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1227888 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/container_url_test.js > 1227888 > > Diff: https://reviews.apache.org/r/3402/diff > > > Testing > ------- > > Ran unit tests and tested in the sample common container and embedded > experiences container. > > > Thanks, > > Ryan > >
