----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3064/#review4719 -----------------------------------------------------------
seems okay. I wish I had the time to use Request-Scoped guice injection instead of all this manual wiring... - Paul On 2011-12-12 21:22:49, Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3064/ > ----------------------------------------------------------- > > (Updated 2011-12-12 21:22:49) > > > Review request for shindig. > > > Summary > ------- > > It would be nice if the GrantRequestHandler had access to the original > request object so that it could use values like the security token to pass > along additional params to the authorization code request. In our > implementation we set values within the security token's trusted json field > that we'd like to pass along to our GrantRequestHandler implementation. > > > This addresses bug SHINDIG-1672. > https://issues.apache.org/jira/browse/SHINDIG-1672 > > > Diffs > ----- > > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2RequestParameterGenerator.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestParameterGenerator.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandler.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java > 1212126 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java > 1212126 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandlerTest.java > 1212126 > > Diff: https://reviews.apache.org/r/3064/diff > > > Testing > ------- > > Added unit test in CodeGrantTypeHandlerTest (testGetCompleteUrl_5). It tests > that the complete url sent to the authentication server has the parameter set > in the accessor. > > > Thanks, > > Doug > >
