----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/ -----------------------------------------------------------
Review request for shindig and Eric Woods. Summary ------- We have a use case that need to support optional parameters on Social REST API. Per open social spec discussion, provider specific parameter can be supported. Please see the link below for details. https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg This patch implemented optional parameter as a field in CollectionOptions. This addresses bug SHINDIG-1698. https://issues.apache.org/jira/browse/SHINDIG-1698 Diffs ----- /trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java 1238916 /trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java 1238916 /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java 1238916 Diff: https://reviews.apache.org/r/3764/diff Testing ------- Passed junit tests. tested with a backend that supports optional parameters. Thanks, li
