Beat me to it! I just remembered I forgot that step. Evgeny, can you also close the review if you haven't done so already.
Thanks, -Stanton From: Henry Saputra <[email protected]> To: [email protected], Date: 02/08/2012 16:49 Subject: Re: Review Request: A patch that enables API for updating person data Evgeny, Could you upload the final patch to JIRA for legal purpose? - Henry On Wed, Feb 8, 2012 at 5:26 AM, Stanton Sievers <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3544/#review4900 > ----------------------------------------------------------- > > Ship it! > > > Committed r1241890 > > Thanks! > > - Stanton > > > On 2012-02-08 12:49:18, Evgeny Bogdanov wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/3544/ >> ----------------------------------------------------------- >> >> (Updated 2012-02-08 12:49:18) >> >> >> Review request for shindig. >> >> >> Summary >> ------- >> >> A patch that enables API for updating person data >> PUT people/12/@self >> osapi.people.update() >> >> >> for this JIRA reports >> https://issues.apache.org/jira/browse/SHINDIG-1674 >> >> >> Diffs >> ----- >> >> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1241411 >> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1241411 >> >> Diff: https://reviews.apache.org/r/3544/diff >> >> >> Testing >> ------- >> >> tests are in the patch >> >> >> Thanks, >> >> Evgeny >> >> >
