----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3885/ -----------------------------------------------------------
Review request for shindig and Ryan Baxter. Summary ------- Added a lifecycle listener to handle when sites were closed so that sites always notify the opener gadget when they close. Before, sites might not get closed through the open-views feature api, and that would result in the oper gadget never getting notified. Also, we notify the opener gadget even if no result has been set so that it at least knows the view has been closed. This addresses bug SHINDIG-1703. https://issues.apache.org/jira/browse/SHINDIG-1703 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1242959 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1242959 Diff: https://reviews.apache.org/r/3885/diff Testing ------- Manual testing with sample gadgets that utilize this feature. Thanks, Dan