-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3959/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I
want to re-enable it and fixup the CheckStyle configuration to match the best
practices on the wiki. It also appears that the CheckStyle configuration
currently in Shindig is an older configuration style - some config has moved in
the file and some attributes have been renamed or invalidated.
As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of
the more obvious style problems.
There are some mismatches between the headers in some of the files. I updated
the java.header to match the header provided in the Eclipse template config,
however, this causes mismatches in some existing files whose headers do not
match. This is one of the "obvious style problems" I mentioned above that I
will fix.
The other obvious things to fix would be trailing whitespace, which can easily
be fixed with a script that runs against all *.java files. If this is worth
fixing, I can do that as well.
This addresses bug SHINDIG-1710.
https://issues.apache.org/jira/browse/SHINDIG-1710
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml
1291013
http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header
1291013
http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013
Diff: https://reviews.apache.org/r/3959/diff
Testing
-------
Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and
examined the checkstyle outputs.
Thanks,
Stanton
