+1
On Sun, Feb 26, 2012 at 1:06 PM, Paul Lindner <[email protected]> wrote: > agreed, please go ahead and commit it. > > I'd also just create a Jira for generic checkstyle fixes. No need to > attach patches, that's what we have source control for. Just reference the > jira and move forward. > > On Sun, Feb 26, 2012 at 12:50 PM, Henry Saputra > <[email protected]>wrote: > >> My take for this kind of massive but trivial changes is to create a >> JIRA and attach the diff to it then simply commit it. >> >> At least we have trail/ record of what changes made for this checkin. >> >> - Henry >> >> On Sun, Feb 26, 2012 at 7:51 AM, Stanton Sievers <[email protected]> >> wrote: >> > Hi everyone, >> > >> > As a followup to the CheckStyle commits I recently made, I wanted to fix >> > some of the most common style problems. One that I'm sure everyone is >> > familiar with is trailing whitespace in files. There are ~1600 offenses >> in >> > the existing code base for *.java files alone according to my most recent >> > Jenkins build. >> > >> > I wanted to drive this number down so that we can focus on "real" >> problems >> > that CheckStyle is finding. So, I wrote a script to kill the whitespace. >> > http://pastebin.com/Qf0FAyfa It might not be the most efficient thing >> in >> > the world but it works for this purpose. >> > >> > Running this script over all of shindig-project touched 500 files and >> > generated a ~750kb patch file that is >800,000 lines long. My question >> to >> > all of you is whether or not this is something worth putting on the >> > reviews.apache.org site or if I should just commit it. >> > >> > Thoughts? >> > >> > -Stanton >> > > > > -- > Paul Lindner -- [email protected] -- profiles.google.com/pmlindner
