----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4090/ -----------------------------------------------------------
Review request for shindig, Ryan Baxter and Stanton Sievers. Summary ------- I recently had need to pass more information (gadget site id) into the ON_RENDER lifecycle event. In order to not break existing impl by changing the current value passed, I wanted to add it as a new param so that required some additional changes. I plan on committing this after Ryan and Stanton review it. It's still a pretty small patch but it's larger than the 1-2 lines I was hoping for, so I wanted something here for informational purposes. Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js 1294801 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1294801 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1294801 Diff: https://reviews.apache.org/r/4090/diff Testing ------- updated tests. Thanks, Dan
