Thanks for the patch! :)
>-----Original Message-----
>From: daviesd [mailto:davi...@oclc.org]
>Sent: Wednesday, March 21, 2012 3:11 PM
>To: dev@shindig.apache.org
>Subject: Re: Review Request: Fix for SHINDIG-1736
>
>Thanks for the "newbie" info. :)
>
>
>On 3/21/12 2:34 PM, "Ciancetta, Jesse E." <jc...@mitre.org> wrote:
>
>> And you also need to be sure to select the radio option for:
>>
>> "Grant license to ASF for inclusion in ASF works"
>>
>> when uploading the patch -- otherwise we can't legally apply it. It doesn¹t
>> look like you did that when attaching the current patch to the JIRA ticket.
>>
>> Sorry for the extra hoops to jump through...
>>
>> --Jesse
>>
>>> -----Original Message-----
>>> From: Henry Saputra [mailto:henry.sapu...@gmail.com]
>>> Sent: Wednesday, March 21, 2012 1:31 PM
>>> To: dev@shindig.apache.org
>>> Subject: Re: Review Request: Fix for SHINDIG-1736
>>>
>>> Dont want to be party pooper but Doug could you attach the patch to
>>> the JIRA associated with this review?
>>>
>>> - Henry
>>>
>>> On Wed, Mar 21, 2012 at 6:38 AM, Ryan J Baxter <rjbax...@us.ibm.com>
>>> wrote:
>>>> I can commit it. I was also waiting for Paul to take a look at it. If he
>>>> doesn't get to it by the end of the day I will commit it.
>>>>
>>>> -Ryan
>>>>
>>>>
>>>>
>>>>
>>>> From: daviesd <davi...@oclc.org>
>>>> To: <dev@shindig.apache.org>, Paul Lindner <lind...@inuus.com>,
>>>> Cc: Ryan Baxter <rbaxte...@gmail.com>
>>>> Date: 03/20/2012 11:04 PM
>>>> Subject: Re: Review Request: Fix for SHINDIG-1736
>>>>
>>>>
>>>>
>>>> Thanks Ryan. How do I go about getting a committer to commit this? I
>was
>>>> hoping Paul would review before then, but I'd love to see this get in
>>>> before
>>>> the next 2.5 beta.
>>>>
>>>> doug
>>>>
>>>>
>>>> On 3/19/12 9:09 AM, "Ryan Baxter" <rbaxte...@gmail.com> wrote:
>>>>
>>>>>
>>>>> -----------------------------------------------------------
>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>> https://reviews.apache.org/r/4366/#review6070
>>>>> -----------------------------------------------------------
>>>>>
>>>>> Ship it!
>>>>>
>>>>>
>>>>> LGTM
>>>>>
>>>>> - Ryan
>>>>>
>>>>>
>>>>> On 2012-03-15 17:47:31, Doug Davies wrote:
>>>>>>
>>>>>> -----------------------------------------------------------
>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>> https://reviews.apache.org/r/4366/
>>>>>> -----------------------------------------------------------
>>>>>>
>>>>>> (Updated 2012-03-15 17:47:31)
>>>>>>
>>>>>>
>>>>>> Review request for shindig and Paul Lindner.
>>>>>>
>>>>>>
>>>>>> Summary
>>>>>> -------
>>>>>>
>>>>>> This is a fix for SHINDIG-1736. Currently the recently updated
>>>> JsonUtil
>>>>>> blows up if the class it is trying to parse has synthetic methods
>>>> generated
>>>>>> by the compiler for handling runtime generics substitution. It now
>>>> checks to
>>>>>> make sure the method is not synthetic. I've included a unit test that
>>>> tests
>>>>>> this scenario.
>>>>>>
>>>>>>
>>>>>> This addresses bug SHINDIG-1736.
>>>>>> https://issues.apache.org/jira/browse/SHINDIG-1736
>>>>>>
>>>>>>
>>>>>> Diffs
>>>>>> -----
>>>>>>
>>>>>>
>>>>
>>>
>/trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.ja
>>> va
>>>>>> 1299867
>>>>>>
>>>>>>
>>>>
>>>
>/trunk/java/common/src/test/java/org/apache/shindig/common/JsonUtilTes
>>> t.java
>>>>>> 1299867
>>>>>>
>>>>>> Diff: https://reviews.apache.org/r/4366/diff
>>>>>>
>>>>>>
>>>>>> Testing
>>>>>> -------
>>>>>>
>>>>>> unit test provided
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Doug
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>
