> On 2012-03-21 22:09:24, Henry Saputra wrote: > > Actually I just noticed something when trying to commit. What is the > > appended-resources directory for? Is it automatically generated by your > > build? Seems like aggregation of the NOTICE and LICENSE files > > Ate Douma wrote: > The appended-resources directory is used by the > maven-remote-resources-plugin in combination with the (default configured) > apache-jar-resource-bundle. > That resource bundle provides the standard ASL 2.0 LICENSE and basic > NOTICE file (as velocity template). > The plugin will look for matching resource *fragments* in the > appended-resources folder and if found append them to the base template from > the resource bundle. > Effectively, this largely reduces the amount and size of to be provided > LICENSE and NOTICE file per artifact/module, as only appendable fragments > need to be provided, if needed at all. > > So the appended-resources directory is *not* automatically generated by > my build but needed and used to generate final and complete LICENSE and > NOTICE files. > > Henry Saputra wrote: > Just committed the patch but looks like you just delete the content of > features/NOTICE and other files instead of deleting the files themselves. Any > reason why we need to have those empty files?
Weird. When I applied the patch myself using Eclipse to validate it, it actually did remove those empty files. Seems to depend on how you apply it or what tool you use. It definitely is the intend to remove those empty files, so I suggest to now manually delete then. Sorry for the inconvenience. - Ate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review6191 ----------------------------------------------------------- On 2012-03-15 13:10:51, Ate Douma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3887/ > ----------------------------------------------------------- > > (Updated 2012-03-15 13:10:51) > > > Review request for shindig. > > > Summary > ------- > > This is a patch for resolving the remaining legal NOTICE and LICENSE > requirements as reported here: > http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3c4f20c2d2.9030...@douma.nu%3E > > The patch also includes fixes needed for Shindig PHP, and updated Copyright > and license claim for OpenSocial 0.8 usages, see also: > https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J > > > This addresses bug SHINDIG-1689. > https://issues.apache.org/jira/browse/SHINDIG-1689 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336 > http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336 > http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336 > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336 > http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336 > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336 > http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336 > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336 > http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336 > > Diff: https://reviews.apache.org/r/3887/diff > > > Testing > ------- > > > Thanks, > > Ate > >
