----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4521/#review6426 -----------------------------------------------------------
Ship it! LGTM In case others aren't familiar with the method: http://htmlunit.sourceforge.net/apidocs/com/gargoylesoftware/htmlunit/WebClient.html#waitForBackgroundJavaScript(long) - Dan On 2012-03-27 07:49:15, Evgeny Bogdanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4521/ > ----------------------------------------------------------- > > (Updated 2012-03-27 07:49:15) > > > Review request for shindig. > > > Summary > ------- > > Patch for this issue: https://issues.apache.org/jira/browse/SHINDIG-1694 > > Please review. > > Actually, it accidentally went into trunk already with this patch: > https://reviews.apache.org/r/3544/ > Sorry, I forgot to remove it when generated the patch. > > So depending on the review we either remove it or do nothing. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java > 1238498 > > Diff: https://reviews.apache.org/r/4521/diff > > > Testing > ------- > > > Thanks, > > Evgeny > >
