----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/ -----------------------------------------------------------
(Updated 2012-04-10 03:17:11.958169) Review request for shindig, Ryan Baxter, Eric Woods, and Stanton Sievers. Changes ------- Hi Ryan, I have update the patch per your comments. Thanks! Summary ------- This is the patch for https://reviews.apache.org/r/3764 as xuli is not working on it. @Ryan, I have merged line 58 and 59 of /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java and break line 60 into multiple lines. As predefinedParameters is using RequestItem, it can not be changed to private static final. This addresses bug SHINDIG-1698. https://issues.apache.org/jira/browse/SHINDIG-1698 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java 1311182 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java 1311182 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java 1311182 Diff: https://reviews.apache.org/r/4680/diff Testing ------- done Thanks, Yao
