----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6827 -----------------------------------------------------------
Comments in line. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java <https://reviews.apache.org/r/4291/#comment15200> I'm not a fan of having _gadgetUri and gadgetUri both in scope at the same time. It makes things hard to read in my opinion. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java <https://reviews.apache.org/r/4291/#comment15201> Same as the _gadgetUri and gadgetUri comments above. - Stanton On 2012-04-10 15:00:53, Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4291/ > ----------------------------------------------------------- > > (Updated 2012-04-10 15:00:53) > > > Review request for shindig, Ryan Baxter and li xu. > > > Summary > ------- > > Allows multiple gadgets to share a token by binding to an OAuth2Client with > sharedToken=true > > > This addresses bug SHINDIG-1731. > https://issues.apache.org/jira/browse/SHINDIG-1731 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1311719 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared1.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_google_shared2.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > 1311719 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java > 1311719 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java > 1311719 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java > 1311719 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java > 1311719 > > Diff: https://reviews.apache.org/r/4291/diff > > > Testing > ------- > > All test cases pass. > > > Thanks, > > Adam > >
