----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#review6838 -----------------------------------------------------------
Looks like some things were missed when pulling the results feature out. See inline comments. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15229> Why is this here? I thought this was part of the new results feature? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15230> Same as setReturnValue above http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15232> I don't see this being used. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15233> I don't see this being used either. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15231> Same as setReturnValue above. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15234> This isn't being used. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js <https://reviews.apache.org/r/4693/#comment15228> Whitespace - Stanton On 2012-04-10 20:35:22, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4693/ > ----------------------------------------------------------- > > (Updated 2012-04-10 20:35:22) > > > Review request for shindig. > > > Summary > ------- > > Broke features apart into smaller features. > > Updated mixin function in common container to allow you to mix several of the > same namespace in. > > > This addresses bug SHINDIG-1721. > https://issues.apache.org/jira/browse/SHINDIG-1721 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1311965 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt > 1311965 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml > 1311965 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js > 1311965 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js > 1311965 > > Diff: https://reviews.apache.org/r/4693/diff > > > Testing > ------- > > All existing tests pass > > > Thanks, > > Dan > >
