----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4706/#review6870 -----------------------------------------------------------
Ship it! This looks good to me. My only request is that you add some javadoc to each of the protected methods. In addition, having a one-liner for each one of the form "override this method if you want to _______" would be great. - Stanton On 2012-04-12 02:09:46, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4706/ > ----------------------------------------------------------- > > (Updated 2012-04-12 02:09:46) > > > Review request for shindig. > > > Summary > ------- > > Refactor DefaultRequestPipeline to be easier to be overridden by breaking the > long execute method to small protected methods. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java > 1325046 > > Diff: https://reviews.apache.org/r/4706/diff > > > Testing > ------- > > Pass unit test > > > Thanks, > > Henry > >
