----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4789/#review7006 -----------------------------------------------------------
Ship it! +1 - Stanton On 2012-04-18 14:54:36, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4789/ > ----------------------------------------------------------- > > (Updated 2012-04-18 14:54:36) > > > Review request for shindig and Dan Dumont. > > > Summary > ------- > > If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default > post size will be 0 instead of the actual default size because > ContainerConfig.getInt returns 0 when the property is missing not null. > > > This addresses bug SHINDIG-1752. > https://issues.apache.org/jira/browse/SHINDIG-1752 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1326802 > > Diff: https://reviews.apache.org/r/4789/diff > > > Testing > ------- > > Ran unit tests > > > Thanks, > > Ryan > >
