----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/#review7012 -----------------------------------------------------------
Ship it! LGTM just one small nit trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java <https://reviews.apache.org/r/4760/#comment15587> small nit, change the variable name from entry to list - Ryan On 2012-04-17 23:17:54, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4760/ > ----------------------------------------------------------- > > (Updated 2012-04-17 23:17:54) > > > Review request for shindig. > > > Summary > ------- > > Fix the REST endpoints to follow the latest OpenSocial specs to wrap > collection with "list" element. > > > This addresses bug SHINDIG-1677. > https://issues.apache.org/jira/browse/SHINDIG-1677 > > > Diffs > ----- > > > trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java > 1326759 > > trunk/java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java > 1326759 > > trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java > 1326759 > > trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/RestfullCollectionConverter.java > 1326759 > > trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java > 1326759 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityTest.java > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlActivityTest.java > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml > 1326759 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1326759 > > trunk/java/social-api/src/test/resources/org/apache/shindig/social/opensocial/util/opensocial.xsd > 1326759 > > Diff: https://reviews.apache.org/r/4760/diff > > > Testing > ------- > > Fixed unit tests for collection and passed the unit tests for single element. > > > Thanks, > > Henry > >
