-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
See the JIRA for the high-level overview.
I'm looking for feedback on how to best configure EhCache out-of-the-box for
Shindig. I've tried to pick configuration that makes sense for most simple
deployments.
I'm also looking for feedback on how to best configure the SizeOf filter.
Right now I'm setting it in the system properties from the provider code but
could just as easily set it in the web.xml. I have it in the provider code
today because that's where we read in the rest of the config. Will security
manager's in real world deployments block the call to
System.getProperties().put()?
This addresses bug SHINDIG-1746.
https://issues.apache.org/jira/browse/SHINDIG-1746
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java
1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java
1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml
1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java
1329784
http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784
Diff: https://reviews.apache.org/r/4856/diff
Testing
-------
Existing tests pass with the update. I'm not sure what else can be tested via
JUnit for these changes.
In testing I did utilize JMX and heap dump analysis to understand and verify
that caches were being allocated appropriately. I have documented the steps I
took and will publish a wiki article once these changes are in.
Thanks,
Stanton
