----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4818/#review7243 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/CoreUtilConfigContributor.java <https://reviews.apache.org/r/4818/#comment15976> This seems the wrong approach for me. Each ConfigContributor responsible to add additional config from server. In this case the CoreUtilConfigContributor is used to add additional logic to push config to init function in the core.util feature. Not sure how the opensocial-templates JS code could read this new rewritten requireLibrary param. - Henry On 2012-04-25 02:27:27, Erik Bi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4818/ > ----------------------------------------------------------- > > (Updated 2012-04-25 02:27:27) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Summary > ------- > > per spec, Gadget should be able to use relative URL to define the > template-libray, but right now when it uses this approach, client side will > end up making a /gadgets/makeRequest call and passes in the relative URL > value and fails with an HTTP status of 400. > > Solution: > At client side, the opensocial-template feature will get the template-library > URL value from global variable "features", so in this patch it updates the > process of generating the init JS which will be passed back to client side to > init the "features" variable(in Class > "org.apache.shindig.gadgets.config.CoreUtilConfigContributor"), adds some > specific logic to handle "template-library" parameter, convert the relative > url to an absolute one. > > > This addresses bug shindig-1548. > https://issues.apache.org/jira/browse/shindig-1548 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/CoreUtilConfigContributor.java > 1327432 > > Diff: https://reviews.apache.org/r/4818/diff > > > Testing > ------- > > > Thanks, > > Erik > >
