----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/#review7280 -----------------------------------------------------------
Ship it! +1 LGTM - Henry On 2012-04-26 20:59:58, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4898/ > ----------------------------------------------------------- > > (Updated 2012-04-26 20:59:58) > > > Review request for shindig. > > > Summary > ------- > > These changes are needed to align with the OpenSocial 2.5 proposal to create > an API allowing gadgets to register for a listener to receive the embedded > experiences context. > > > http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences > > > http://code.google.com/p/opensocial-resources/issues/detail?id=1249 > > > This addresses bug SHINDIG-1760. > https://issues.apache.org/jira/browse/SHINDIG-1760 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml > 1331043 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js > 1331043 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml > 1331043 > > Diff: https://reviews.apache.org/r/4898/diff > > > Testing > ------- > > Tested with sample gadgets in the embedded experiences container. > > > Thanks, > > Ryan > >
