----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4877/#review7314 -----------------------------------------------------------
Ship it! Committed r1331528 - Dan On 2012-04-26 02:15:03, Xiao Feng Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4877/ > ----------------------------------------------------------- > > (Updated 2012-04-26 02:15:03) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Brian Lillie. > > > Summary > ------- > > Since max-age=0 means the response expires immediately when the response is > generated, and there is no need to compute TTL with possibly incorrect server > time. > We can update the isStale method in HttpResponse to return true if max-age > equals 0 instead of relying on computed TTL. > > > This addresses bug SHINDIG-1759. > https://issues.apache.org/jira/browse/SHINDIG-1759 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java > 1330087 > > Diff: https://reviews.apache.org/r/4877/diff > > > Testing > ------- > > > Thanks, > > Xiao Feng > >
