----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4951/#review7465 -----------------------------------------------------------
Ship it! LGTM - Stanton On 2012-05-01 19:07:56, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4951/ > ----------------------------------------------------------- > > (Updated 2012-05-01 19:07:56) > > > Review request for shindig. > > > Summary > ------- > > Implementors may now choose to provide the site element via an async callback > so in case circumstances force them to need to do that. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js > 1332778 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js > 1332778 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > 1332778 > > Diff: https://reviews.apache.org/r/4951/diff > > > Testing > ------- > > All tests still pass. All original functionality is still supported. > > > Thanks, > > Dan > >
