----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/#review7571 -----------------------------------------------------------
LGTM, besides the JS doc. I applied the patch build, and tested everything out and things seem to be working. trunk/features/src/main/javascript/features/embeddedexperiences/constant.js <https://reviews.apache.org/r/4976/#comment16755> Add some JS doc for these - Ryan On 2012-05-04 16:29:28, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4976/ > ----------------------------------------------------------- > > (Updated 2012-05-04 16:29:28) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec: > http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model > http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences > > I remove the unneeded model for EmbeddedExperience because ActivityEntry uses > ExtendableBean, which act like a Map, to store opensocial and its extension > so there is no need to explicitly map embed or preferredExperience with > physical class: > java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java > java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java > > > This addresses bug SHINDIG-1762. > https://issues.apache.org/jira/browse/SHINDIG-1762 > > > Diffs > ----- > > trunk/content/sampledata/canonicaldb.json 1333592 > trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js > 1333592 > trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml > PRE-CREATION > trunk/features/src/main/javascript/features/embeddedexperiences/constant.js > 1333592 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1333592 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js > 1333592 > trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml > 1333592 > > trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > 1333592 > > trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js > 1333592 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java > 1333592 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java > 1333592 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java > 1333592 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json > 1333592 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json > 1333592 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1333592 > > Diff: https://reviews.apache.org/r/4976/diff > > > Testing > ------- > > Updated the unit tests and modify EE sample gadget to test passing additional > context and respect preferredExperience display link text. > > > Thanks, > > Henry > >
