----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4906/#review7766 -----------------------------------------------------------
Ship it! LGTM. I removed the whitespace for you. Please close the review. Committed revision 1336646 - Ryan On 2012-05-10 06:49:27, qiaoyun sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4906/ > ----------------------------------------------------------- > > (Updated 2012-05-10 06:49:27) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Summary > ------- > > If we don't set this property in shindig.properties: > shindig.urlgen.use-templates-default=false, the lang and country info will > not pass to the ifr url, so the lang and country are ignored. > For example: the ifr is like : > http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0 > > They should be substituted by the browser's setting in client side. > > > This addresses bug SHINDIG-1763. > https://issues.apache.org/jira/browse/SHINDIG-1763 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js > 1331177 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js > 1331168 > > Diff: https://reviews.apache.org/r/4906/diff > > > Testing > ------- > > > Thanks, > > qiaoyun > >
