> On 2012-05-10 16:51:58, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js, > > line 36 > > <https://reviews.apache.org/r/5087/diff/2/?file=108385#file108385line36> > > > > I was wondering if I can push the pattern /gadgets/js to > > shindig.properties or container.js for easy configuration change? > > Stanton Sievers wrote: > Henry, I don't think we have access to config at this point. This > routine is the first to be called once init.js has loaded, so none of the > config has be initialized yet.
Yeah your are right, this code is executed very early. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5087/#review7776 ----------------------------------------------------------- On 2012-05-10 16:46:50, Mike May wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5087/ > ----------------------------------------------------------- > > (Updated 2012-05-10 16:46:50) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Summary > ------- > > init.js assumes the feature URL for the JS servlet is the last script tag > when this will not always be the case. > > > This addresses bug SHINDIG-1774. > https://issues.apache.org/jira/browse/SHINDIG-1774 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js > 1336780 > > Diff: https://reviews.apache.org/r/5087/diff > > > Testing > ------- > > All tests pass. > > Local testing done. > > > Thanks, > > Mike > >
