----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5113/#review7890 -----------------------------------------------------------
Sorry for the second review, but can you also fixup your Bug link. All you need is "SHINDIG-1777", you don't need the full URL. Thanks. - Stanton On 2012-05-14 18:56:35, Erin Noe-Payne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5113/ > ----------------------------------------------------------- > > (Updated 2012-05-14 18:56:35) > > > Review request for shindig. > > > Summary > ------- > > > pubsub-2 appends an rpc token with a hashtag to the open gadget url. When > the url parameters are split by '&', hash tags are skipped and json.parse > fails on the resulting parameter. > > Switched to global replace to avoid the issue. > > > This addresses bug https://issues.apache.org/jira/browse/SHINDIG-1777. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SHINDIG-1777 > > > Diffs > ----- > > > trunk/features/src/main/javascript/features/core.util.urlparams/urlparams.js > 1338216 > > Diff: https://reviews.apache.org/r/5113/diff > > > Testing > ------- > > Chrome, FF 12, IE 8/9 > > > Thanks, > > Erin > >
