----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/#review7972 -----------------------------------------------------------
Ship it! LGTM. Having an additional MakeRequestHandlerTest that verifies that the user-agent is ferried along would be a welcome addition to the patch. - Stanton On 2012-05-18 16:21:01, Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5162/ > ----------------------------------------------------------- > > (Updated 2012-05-18 16:21:01) > > > Review request for shindig. > > > Summary > ------- > > Passes the User-Agent header so intermediate (or even backend processing) can > make browser-specific customizations. > > > This addresses bug SHINDIG-1781. > https://issues.apache.org/jira/browse/SHINDIG-1781 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1340074 > > Diff: https://reviews.apache.org/r/5162/diff > > > Testing > ------- > > All tests pass. > > > Thanks, > > Adam > >
