----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/#review7999 -----------------------------------------------------------
I would like to see some JUnit tests for either the ProxyServlet or the ProxyUri (or both) to make sure that the auth param and OAuth params are getting set and ferried along properly. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java <https://reviews.apache.org/r/5112/#comment17362> Is there a reason why this logic for setting the gadget and OAuth params on the ProxyUri cannot occur in ProxyUri.setFromUri() where you're already setting the auth type? - Stanton On 2012-05-20 13:18:46, Xiao Feng Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5112/ > ----------------------------------------------------------- > > (Updated 2012-05-20 13:18:46) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Brian Lillie. > > > Summary > ------- > > Couple of changes are included in this patch. > 1) On the client side, the getProxyUrl is updated to add auth parameter to > specify the auth scheme used, also check for the AUTHORIZATION and > OAUTH_SERVICE setting and add them in proxy url. > 2) On the server side, proxy servlet will pass additional HttpServletRequest > to ProxyHandler to build the HttpRequest object, in the ProxyHandler > additional information as security token, auth type, oauth service and gadget > will be used to construct a HttpRequest to pass to the DefaultRequestPipeline > for handling. > > > This addresses bug Shindig-1773. > https://issues.apache.org/jira/browse/Shindig-1773 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1340509 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js > 1340511 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js > 1340511 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java > 1340509 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java > 1340509 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java > 1340509 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriCommon.java > 1340509 > > http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml > 1340509 > > Diff: https://reviews.apache.org/r/5112/diff > > > Testing > ------- > > > Thanks, > > Xiao Feng > >
