-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/
-----------------------------------------------------------

(Updated 2012-05-22 18:20:43.399280)


Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian 
Lillie.


Changes
-------

updated the format


Summary
-------

Couple of changes are included in this patch.
1) On the client side, the getProxyUrl is updated to add auth parameter to 
specify the auth scheme used, also check for the AUTHORIZATION and 
OAUTH_SERVICE setting and add them in proxy url.
2) On the server side, proxy servlet will pass additional HttpServletRequest to 
ProxyHandler to build the HttpRequest object, in the ProxyHandler additional 
information as security token, auth type, oauth service and gadget will be used 
to construct a HttpRequest to pass to the DefaultRequestPipeline for handling.


This addresses bug Shindig-1773.
    https://issues.apache.org/jira/browse/Shindig-1773


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1341572 
  http://svn.apache.org/repos/asf/shindig/trunk/config/oauth2.json 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json
 1340019 
  
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/oauth2/oauth2_spring_proxy.xml
 PRE-CREATION 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriManager.java
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriCommon.java
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
 1341572 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml
 1341572 

Diff: https://reviews.apache.org/r/5112/diff


Testing
-------


Thanks,

Xiao Feng

Reply via email to